Hello

I can't renew certs (or create new certs) since the 0.10 upgrade. was working fine before on 0.9

I'm basically getting the same output everytime i run this command.
 

xander /var/www/froxlor # /usr/bin/php7.3 -q /var/www/froxlor/scripts/froxlor_master_cronjob.php --letsencrypt --debug
[information] Requesting/renewing Let's Encrypt certificates
[information] Creating certificate for Westecheurope.eu
[information] Adding SAN entry: Westecheurope.eu
[information] Adding SAN entry: www.Westecheurope.eu
[Mon  4 Nov 11:23:46 CET 2019] It is recommended to install socat first.
[Mon  4 Nov 11:23:46 CET 2019] We use socat for standalone server if you use standalone mode.
[Mon  4 Nov 11:23:46 CET 2019] If you don't use standalone mode, just ignore this warning.
[information] Checking for LetsEncrypt client upgrades before renewing certificates:
[Mon  4 Nov 11:23:45 CET 2019] Installing from online archive.
[Mon  4 Nov 11:23:45 CET 2019] Downloading https://github.com/Neilpang/acme.sh/archive/master.tar.gz
[Mon  4 Nov 11:23:46 CET 2019] Extracting master.tar.gz
[Mon  4 Nov 11:23:46 CET 2019] Installing to /root/.acme.sh
[Mon  4 Nov 11:23:46 CET 2019] Installed to /root/.acme.sh/acme.sh
[Mon  4 Nov 11:23:46 CET 2019] Good, bash is found, so change the shebang to use bash as preferred.
[Mon  4 Nov 11:23:47 CET 2019] OK
[Mon  4 Nov 11:23:47 CET 2019] Install success!
[Mon  4 Nov 11:23:47 CET 2019] Upgrade success!
[Mon  4 Nov 11:23:47 CET 2019] Removing cron job
[Mon  4 Nov 11:23:52 CET 2019] get to authz error.
[Mon  4 Nov 11:23:52 CET 2019] _authorizations_map='www.westecheurope.eu,{"identifier":{"type":"dns","value":"www.westecheurope.eu"},"status":"pending","expires":"2019-11-07T18:17:12Z","challenges":[{"type":"http-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077162/e3Lmew","token":"H07E0jvAJ-vnQ4jirnVIxqLeRxDwQ_VC6PQ0RAJgEvU"},{"type":"dns-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077162/rs0T6w","token":"H07E0jvAJ-vnQ4jirnVIxqLeRxDwQ_VC6PQ0RAJgEvU"},{"type":"tls-alpn-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077162/ZPjfSg","token":"H07E0jvAJ-vnQ4jirnVIxqLeRxDwQ_VC6PQ0RAJgEvU"}]}
westecheurope.eu,{"identifier":{"type":"dns","value":"westecheurope.eu"},"status":"pending","expires":"2019-11-07T18:17:12Z","challenges":[{"type":"http-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077160/hOWGhQ","token":"Bd7XDicTn8dtJBIYc9Eod2d7eOxZGba42pnnl5aCNyI"},{"type":"dns-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077160/nj7_Ow","token":"Bd7XDicTn8dtJBIYc9Eod2d7eOxZGba42pnnl5aCNyI"},{"type":"tls-alpn-01","status":"pending","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/1025077160/v7Bc7A","token":"Bd7XDicTn8dtJBIYc9Eod2d7eOxZGba42pnnl5aCNyI"}]}
'
[Mon  4 Nov 11:23:52 CET 2019] Please add '--debug' or '--log' to check more details.
[Mon  4 Nov 11:23:52 CET 2019] See: https://github.com/Neilpang/acme.sh/wiki/How-to-debug-acme.sh
[debug] [Mon  4 Nov 11:23:48 CET 2019] Creating domain key
[Mon  4 Nov 11:23:49 CET 2019] The domain key is here: /root/.acme.sh/Westecheurope.eu/Westecheurope.eu.key
[Mon  4 Nov 11:23:49 CET 2019] Multi domain='DNS:Westecheurope.eu,DNS:www.Westecheurope.eu'
[Mon  4 Nov 11:23:50 CET 2019] Getting domain auth token for each domain
[Mon  4 Nov 11:23:52 CET 2019] Getting webroot for domain='Westecheurope.eu'
[error] Could not get Let's Encrypt certificate for Westecheurope.eu:
[Mon  4 Nov 11:23:48 CET 2019] Creating domain key
[Mon  4 Nov 11:23:49 CET 2019] The domain key is here: /root/.acme.sh/Westecheurope.eu/Westecheurope.eu.key
[Mon  4 Nov 11:23:49 CET 2019] Multi domain='DNS:Westecheurope.eu,DNS:www.Westecheurope.eu'
[Mon  4 Nov 11:23:50 CET 2019] Getting domain auth token for each domain
[Mon  4 Nov 11:23:52 CET 2019] Getting webroot for domain='Westecheurope.eu'
[information] No new certificates or certificates due for renewal found
[notice] Checking system's last guid

 

seems to be an acme.sh bug, see https://github.com/Neilpang/acme.sh/issues/2556

The following changes to lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php should fix that for us:

diff --git a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php
index 8fc4952b..545ad323 100644
--- a/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php
+++ b/lib/Froxlor/Cron/Http/LetsEncrypt/AcmeSh.php
@@ -209,7 +209,7 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron
 
                        if ($cert_mode) {
                                $domains = array(
-                                       $certrow['domain']
+                                       strtolower($certrow['domain'])
                                );
 
                                $froxlor_aliases = Settings::Get('system.froxloraliases');
@@ -217,7 +217,7 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron
                                        $froxlor_aliases = explode(",", $froxlor_aliases);
                                        foreach ($froxlor_aliases as $falias) {
                                                if (\Froxlor\Validate\Validate::validateDomain(trim($falias))) {
-                                                       $domains[] = trim($falias);
+                                                       $domains[] = strtolower(trim($falias));
                                                }
                                        }
                                }
@@ -269,12 +269,12 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron
 
                                $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_INFO, "Adding SAN entry: " . $certrow['domain']);
                                $domains = array(
-                                       $certrow['domain']
+                                       strtolower($certrow['domain'])
                                );
                                // add www.<domain> to SAN list
                                if ($certrow['wwwserveralias'] == 1) {
                                        $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_INFO, "Adding SAN entry: www." . $certrow['domain']);
-                                       $domains[] = 'www.' . $certrow['domain'];
+                                       $domains[] = strtolower('www.' . $certrow['domain']);
                                }
 
                                // add alias domains (and possibly www.<aliasdomain>) to SAN list
@@ -284,10 +284,10 @@ class AcmeSh extends \Froxlor\Cron\FroxlorCron
                                $aliasdomains = $aliasdomains_stmt->fetchAll(\PDO::FETCH_ASSOC);
                                foreach ($aliasdomains as $aliasdomain) {
                                        $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_INFO, "Adding SAN entry: " . $aliasdomain['domain']);
-                                       $domains[] = $aliasdomain['domain'];
+                                       $domains[] = strtolower($aliasdomain['domain']);
                                        if ($aliasdomain['wwwserveralias'] == 1) {
                                                $cronlog->logAction(FroxlorLogger::CRON_ACTION, LOG_INFO, "Adding SAN entry: www." . $aliasdomain['domain']);
-                                               $domains[] = 'www.' . $aliasdomain['domain'];
+                                               $domains[] = strtolower('www.' . $aliasdomain['domain']);
                                        }
                                }

 

you're a godsend !  Fast reply and right on target ! 

 

I simply renamed the domain in the DB. and renewal went straight thru  
+ Feature request : lowercase domain names when adding them to froxlor