HTTP 500 in /admin_domains.php

[princeofnaxos]

Trying to edit a domain in Froxlor 0.10, I end up with a 500 error. The Apache error log says: 

```

[Fri Dec 28 14:44:26.521632 2018] [php7:error] [pid 27116] [client 83.248.199.185:62145] PHP Fatal error:  Uncaught Error: Access to undeclared static property: Froxlor\\UI\\HtmlForm::$_form in /var/www/froxlor.0-10/lib/Froxlor/UI/HtmlForm.php(52) : eval()'d code:1\nStack trace:\n#0 /var/www/froxlor.0-10/lib/Froxlor/UI/HtmlForm.php(52): eval()\n#1 /var/www/froxlor.0-10/admin_domains.php(630): Froxlor\\UI\\HtmlForm::genHTMLForm(Array)\n#2 {main}\n  thrown in /var/www/froxlor.0-10/lib/Froxlor/UI/HtmlForm.php(52) : eval()'d code on line 1, referer: https://froxlor.fasterminds.com/admin_domains.php?page=domains&s=1c0e3a2e7e88e9eeeb66e5c0efc09ab7

```

 

[d00p]

try this:

diff --git a/lib/Froxlor/UI/HtmlForm.php b/lib/Froxlor/UI/HtmlForm.php
index 0858585c..99273b9a 100644
--- a/lib/Froxlor/UI/HtmlForm.php
+++ b/lib/Froxlor/UI/HtmlForm.php
@@ -49,7 +49,7 @@ class HtmlForm
                                }
 
                                if (! isset($section['nobuttons']) || $section['nobuttons'] == false) {
-                                       eval("self::\$_form .= \"" . Template::getTemplate("misc/form/table_section", "1") . "\";");
+                                       eval("self::\$form .= \"" . Template::getTemplate("misc/form/table_section", "1") . "\";");
                                } else {
                                        $nob = true;
                                }
@@ -74,7 +74,7 @@ class HtmlForm
                                                } else {
                                                        $nexto = false;
                                                }
-                                               eval("self::\$_form .= \"" . Template::getTemplate("misc/form/table_row", "1") . "\";");
+                                               eval("self::\$form .= \"" . Template::getTemplate("misc/form/table_row", "1") . "\";");
                                        } else {
                                                $data_field = self::parseDataField($fieldname, $fielddata);
                                                $data_field = str_replace("\t", "", $data_field);
@@ -88,7 +88,7 @@ class HtmlForm
 
                // add save/reset buttons at the end of the form
                if (! $nob) {
-                       eval("self::\$_form .= \"" . Template::getTemplate("misc/form/table_end", "1") . "\";");
+                       eval("self::\$form .= \"" . Template::getTemplate("misc/form/table_end", "1") . "\";");
                }
 
                return self::$form;

 

[princeofnaxos]

40 minutes ago, d00p said:

Patch didn't work, but editing $_form into $form did the trick.